Merge libs/form into app/components#798
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Preview will be deployed at https://console-git-collapse-form-lib.internal.oxide.computer |
david-crespo
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the integration demo today I was looking into improving the disk size input field but the question of where to put it kind of made me pause. After thinking about this a bit longer it made me realize that having our form fields in a standalone lib no longer makes sense.
@david-crespo already raised this but at the time I was thinking of the forms lib as a potentially portable library. It's highly console specific though with logic like validation directly baked into it. After considering more, I believe my initial inclination wasn't right. Further, I suspect the same is true of the pagination and table libraries.